search

readchina / comics

Comics repo
https://readchina.github.io/comics/
1 stars 0 forks source link

more fixes #30

Closed duncdrum closed 2 years ago

duncdrum commented 2 years ago

edit button, fixes a broken page favicon will appear in some browesers, most of the time …

sponsor footer will have to wait for tomorrow

damianodamiani commented 2 years ago

favicon appears, nice!

For the edit button: Maybe we explain it a bit, so instead of "Edit this page" --> "Suggest edits or improvements via GitHub here" or something like this?

damianodamiani commented 2 years ago

images work now, still no footer though

damianodamiani commented 2 years ago

the local build still has no footer for me, let me know when it's ready to merge and I will check again :)

duncdrum commented 2 years ago

@damianodamiani you can see the footer when you select either light or dark theme in the config , making it adjust automatically with auto Is still wip

duncdrum commented 2 years ago

@damianodamiani making the edit button text this verbose, seem overkill tbh. It's a button not the documentation, let' rely on convention over configuration.

LenaHenningsen commented 2 years ago

I had a look and it looks beautiful! Thanks so much. Damian, if you agree, we can merge.

damianodamiani commented 2 years ago

changed the logos, from my side now all good to go! I still want to change the 'edit' thingy, will open an issue for that