search

readchina / comics

Comics repo
https://readchina.github.io/comics/
1 stars 0 forks source link

edits of comics page #41

Closed LenaHenningsen closed 2 years ago

LenaHenningsen commented 2 years ago

I just spotted a typo on the comics page and changed that using the edit button and committed, I think. But how does that get into a PR?

duncdrum commented 2 years ago

Screenshot 2022-04-27 at 14 24 07

when using the button on the webpage you have a choice to commit directly to the main branch vs creating a PR .

LenaHenningsen commented 2 years ago

Ok, I think I did that. (the typo was in the Crespi reference Chinese vs. Chiense.) has that been changed now?

Sorry, I have to go now.

Lena

Von: Duncan Paterson @.> Antworten an: readchina/comics @.> Datum: Mittwoch, 27. April 2022 um 14:25 An: readchina/comics @.> Cc: LenaHenningsen @.>, Author @.***> Betreff: Re: [readchina/comics] edits of comics page (Issue #41)

when using the button on the webpage you have a choice to commit directly to the main branch vs creating a PR .

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

duncdrum commented 2 years ago

yup you did, the fix is live. Small fixes like this don't require a PR.

LenaHenningsen commented 2 years ago

THanks

Von: Duncan Paterson @.> Antworten an: readchina/comics @.> Datum: Mittwoch, 27. April 2022 um 15:01 An: readchina/comics @.> Cc: LenaHenningsen @.>, Author @.***> Betreff: Re: [readchina/comics] edits of comics page (Issue #41)

yup you did, the fix is live. Small fixes like this don't require a PR.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>