search

readchina / comics

Comics repo
https://readchina.github.io/comics/
1 stars 0 forks source link

Fix submodule deployment #50

Closed whalekeykeeper closed 1 year ago

whalekeykeeper commented 1 year ago

There are 2 commits.

@duncdrum Could you have a look at the first one? All the changes comes from the git clone --recurse-submodules --remote-submodules https://github.com/readchina/comics.git command after I deleted the existed local directory and re-cloned it with the git command.

The second commit is just to update a few action versions.

see #46 #49

duncdrum commented 1 year ago

@whalekeykeeper the upstream changes look good on a quick glance. The question is if the changes from the feature-next branch have been merged upstream or not.

Basically you can run a local build and inspect the page to see if it looks and works like it is supposed to. You can then compare by cd... ing into the submodule, changing its branch and then cd back up and run another build.

If you are still unsure, can you post some screenshots here?