search

readthedocs / addons

JavaScript client to integrate with Read the Docs nicely
https://readthedocs-addons.readthedocs.io/
MIT License
22 stars 6 forks source link

EthicalAds: migrate code from old embed `.js` #308

Closed humitos closed 6 months ago

humitos commented 6 months ago

Take a look at https://github.com/readthedocs/addons/pull/295#discussion_r1600336686 where there is more context about this. In simple words, we need to copy/re-implement the code we have in Read the Docs (as publisher) to position and style the ad properly according the theme its using.

In a future version, we will be adding other positioning and styles based on other doc tools.

humitos commented 6 months ago

I found there are some logic based on READTHEDOCS_DATA injected -- so, we won't be able to use that approach in when re-writing this code. I will start pretty simple for now and we can grow after that.

humitos commented 6 months ago

This was done in #295