search

readthedocs / addons

JavaScript client to integrate with Read the Docs nicely
https://readthedocs-addons.readthedocs.io/
MIT License
22 stars 6 forks source link

Search: arrow keys navigation is inconsistent and skips entries #316

Closed agjohnson closed 3 months ago

agjohnson commented 6 months ago

The navigation by arrow keys is not what I would expect, I can't tell what the pattern to movement is actually:

Screencast from 2024-05-21 19-53-57.webm

zanderle commented 4 months ago

I believe it's because we're not correctly creating unique IDs for the hits: https://github.com/readthedocs/addons/blob/eae31c8e37d5c62f297486260d6f3a80ec00f705/src/search.js#L263 which is used here: https://github.com/readthedocs/addons/blob/eae31c8e37d5c62f297486260d6f3a80ec00f705/src/search.js#L307

Should be an easy fix if that finding is correct.