search

realthunder / FreeCAD_assembly3

Experimental attempt for the next generation assembly workbench for FreeCAD
GNU General Public License v3.0
885 stars 74 forks source link

Treat objects that are attached to other objects as fixed parts #1288

Closed NomAnor closed 2 years ago

NomAnor commented 2 years ago

I was using a sketch from the Sketch WB to define some geometry so I can attach other parts to it. After constraining the other parts, the placement property of the sketch got some weird angles. I found out that the placement of the sketch was overwritten by the assembly solver.

I find it unintiutive that a sketch that is attached to some face will be repositions by the solver. I added a check to assembly3 that should treat any object with the AttachExtension and a valid AttachmentSuport as a fixed part so the solver will not overwrite the placement.

luzpaz commented 2 years ago

@realthunder if you have a moment, do you mind weighing-in ?

realthunder commented 2 years ago

Thanks for bring this up. I've added a commit for this, but instead of checking for attacher, it checks if the placement is read only.