Open HollyJoyPhillips opened 1 month ago
suggestion: It would be great if we could align Element's Drawer component with the Console Cloud team's react-ui-core
Drawer, as that will make migration for us much simpler. The component API we have has also been battled tested via 100s of drawers in Console Cloud, so we're pretty confident about it's ability to service the drawer pattern defined by the Design System.
suggestion: Given the a11y requirements around modals, it might be best for us to leverage the built-in dialog element. I recently did a POC demonstrating this is possible for both Drawers and Dialogs.
suggestion: It would be great if we could align Element's Drawer component with the Console Cloud team's
react-ui-core
Drawer, as that will make migration for us much simpler. The component API we have has also been battled tested via 100s of drawers in Console Cloud, so we're pretty confident about it's ability to service the drawer pattern defined by the Design System.suggestion: Given the a11y requirements around modals, it might be best for us to leverage the built-in dialog element. I recently did a POC demonstrating this is possible for both Drawers and Dialogs.
As per the Dialog, totally agree with this approach
Abstract
As part of the v5 Elements release, each component will be reviewed and refactored to ensure best practice and design system alignment
Specification
Developer Checklist
Styles Only
andReact
component structuresRelease Checklist
Additional Context or Information