Patch sellingPosition with empty value

reapit / foundations

Foundations platform mono repo

56 stars 22 forks source link

Patch sellingPosition with empty value #10845

Closed chestertons closed 6 months ago

chestertons commented 8 months ago

using sbox applicant MKT240119 PATCH sending Array( [sellingPosition] => [id] => MKT240119 ) 204 status returned, applicant's modified date is updated, but the sellingPosition is not updated

Specification

Project: Reapit.Services.Applicants
Passing sellingPosition as an empty string should cause the field to be cleared in a patch operation, as with other fields. For some reason this is not working. Debug and resolve as appropriate. Omitting the field or passing a null value should result in the field being ignored because of the way we handle patch, but blank string should clear it.

github-actions[bot] commented 8 months ago

Thank you for taking the time to report a bug. We prioritise bugs depending on the severity and implications, so please ensure that you have provided as much information as possible. If you haven’t already, it really helps us to investigate the bug you have reported if you provide ‘Steps to Replicate’ and any associated screenshots. Please ensure any personal information from the production database is obscured when submitting screenshots. This issue will be reviewed in our weekly refinement sessions and assigned to a specific project board. We may also update the ticket to request additional information, if required. For more information on our processes, please click here

AshDeeming commented 8 months ago

Hi @chestertons Please could you confirm what you are attempting to patch? Also has the 'sellingPosition' configuration endpoint been checked?

chestertons commented 8 months ago

Thanks - I'm trying to unset/ reset the selling position for the record to an empty value (ie, the previous value no longer applies, and we do not know the new position) - does that answer the question?

HollyJoyPhillips commented 7 months ago

Hi @chestertons, sorry for the delay coming back to you on this. Yes, there seems to be a bug when setting the selling position as "sellingPosition": "". blank or null will get treated as nothing to update using a PATCH but specifically setting it as "sellingPosition": "" should update the field.

We'll pick this up in refinement tomorrow and from there, it will be allocated to a sprint where it can be fixed. Thanks.