search

reapit / foundations

Foundations platform mono repo
56 stars 22 forks source link

Fallback endpoint for triggering Next Due Date for when PDF upload fails #11095

Open SteveRad opened 6 months ago

SteveRad commented 6 months ago

Is your feature request related to a problem? Please describe. Following https://github.com/reapit/foundations/issues/8939, the workflow fails when the PDF is above 30mb, and therefore it is doesn't kick the 'Next Inspection Due Date' along under the Tenancy Management.

Describe the solution you'd like Would we be able to have an alternative endpoint for kicking this due date along, which executes the same workflow as if the Final PDF was uploaded, therefore we can detect PDF upload fails and ensure we fall back to an endpoint that still does the rest of the flow?

Describe alternatives you've considered Support PDFs up to 100mb :)

github-actions[bot] commented 6 months ago

Thank you for raising a feature request. Feature requests will be prioritised in accordance with our roadmap, customer and developer priorities. This request will be reviewed in our weekly refinement sessions and assigned to a specific project board or column, depending on the nature of the request and the development work required. For more information on our processes, please click here

plittlewood-rpt commented 6 months ago

HI @SteveRad we've discovered whilst triaging this that the ability to upload these documents has actually inadvertently been removed during a codebase migration. We're working to get that restored promptly. The 30Mb limit is imposed to try and ensure developers don't just upload massive files to us and felt a suitable limit. Can you give me some realistic use cases of where the PDFs are larger than this? It would be indicative of bad to no image compression inside the documents and this is something we'd always ask to be reviewed before considering altering this limit. Customers are billed for storage so we do need to retain some control over it. Thanks

github-actions[bot] commented 6 months ago

We have recently requested additional information relating to the issue you have raised. Please can you take the time to review this ticket and where applicable, provide the information requested. For more information on our processes, please click here

RWilcox-Reapit commented 6 months ago

Hi @SteveRad,

We've re-enabled the functionality to support up to 30mb and are awaiting your response to the message above.

Thanks

HollyJoyPhillips commented 5 months ago

I've emailed Steve directly.