search

reapit / foundations

Foundations platform mono repo
57 stars 22 forks source link

Lots of unexpected Webhooks received #11298

Open waters-chris opened 3 months ago

waters-chris commented 3 months ago

Good morning,

We have received lots of unexpected webhook callbacks. They have been 'property modified' callbacks and we appear to have received a callback for all awful lot of our listings - even those that have been archived for years.

For example, on the 1st July we received 2768 webhook callbacks. In the whole of June we received just 499.

In the payload the only difference provided is a new value depositSchemeAccepted.

It feels as though a new field has been added into RPS and we have been sent a webhook callback for each listing with that new field, regardless of whether the listing is current or not.

Thanks, Chris.

github-actions[bot] commented 3 months ago

Thank you for taking the time to report a bug. We prioritise bugs depending on the severity and implications, so please ensure that you have provided as much information as possible. If you haven’t already, it really helps us to investigate the bug you have reported if you provide ‘Steps to Replicate’ and any associated screenshots. Please ensure any personal information from the production database is obscured when submitting screenshots. This issue will be reviewed in our weekly refinement sessions and assigned to a specific project board. We may also update the ticket to request additional information, if required. For more information on our processes, please click here

plittlewood-rpt commented 3 months ago

Hi @waters-chris this is exactly what will have happened. As the webhooks mechanism sends you the full payload, any additional fields will cause an update to come out to you when the branches update those property records. We are planning on reworking webhooks in the future to try and address some of these problems, but for now this is how it currently behaves.

waters-chris commented 3 months ago

Thanks for replying @plittlewood-rpt

Presumably we didn't update the individual properties ourselves though? These were old listings, and I doubt that the staff updated 2700+ listings on the 1st of July to trigger that number of callbacks.

My main concern is the fact that we are charged per callback we receive, meaning that each time there is a change to the API we get hit with a charge we can't avoid (and for listings that we don't care about). While not individually that expensive, over time this will add up to quite the expense.

waters-chris commented 3 months ago

Hi @plittlewood-rpt

Is there anything that can be done regarding a refund for the callbacks that we didn't trigger ourselves? As I said, we didn't trigger those 2700+ callbacks.

Is this something that you can do? Or shall I raise this with our account manager?

Thanks, Chris.