Closed 3dd13 closed 9 years ago
The current version of contextPatch does not work if React > 0.13.1
Hm, this is not good. I can put stricter deps on 0.13.1 for now. Any other ideas?
I haven't read the code and commit log
The reason of having this context patch, is it still a valid reason now with latest react ?
If yes, can make a new context patch with latest react mount/unmount component If no, just remove this patch.
On Monday, May 11, 2015, Nate Wienert notifications@github.com wrote:
Hm, this is not good. I can put stricter deps on 0.13.1 for now. Any other ideas?
— Reply to this email directly or view it on GitHub https://github.com/reapp/reapp-ui/issues/59#issuecomment-100669363.
Ran into the same issue yesterday, I temporarily fixed this as suggested by strictly depending 0.13.1. I'd suggest to also apply this for now to the starter-default repo so scaffolding new apps works: https://github.com/reapp/starter-default/pull/1
0.14 updates in new version (though not fully working, would love help).
when I reapp run, there is an error in web console
after checking the code in facebook/react, the method is not defined in 13.3, but available in 14.0-alpha.
and from the react issue list, the method will be gone in the master after merging the commit too: https://github.com/facebook/react/pull/3711
I am using reapp-kit 1.2.14 and react is on 13.3