fix:#7 Improve Error Handling in smart-contract - Githubissues

reclaimprotocol / reclaim-js-sdk

JavaScript SDK for easy integration of Reclaim Protocol that enables authenticated web data export via HTTPS and zero-knowledge proofs

20 stars 2 forks source link

fix:#7 Improve Error Handling in smart-contract #8

Open shebll opened 1 week ago

shebll commented 1 week ago

Description

Improve Error Handling in smart-contract by extending Error class for making ContractConfigurationError for throw error instead of return undefined
init the jest test config and install jest in -D
move a test folder in src folder for better organizing
make a unit test for getContract
comment other unit tests it makes errors in the testing run
todo for makeBeacon and fix other unit tests

Testing (ignore for documentation update)

init the jest test config and install jest in -D
move a test folder in src folder for better organizing
make a unit test for getContract
comment other unit tests it makes errors in the testing run
todo for makeBeacon and fix other unit tests

Type of change

[x] Bug fix
[ ] New feature
[ ] Breaking change
[ ] Documentation update

Checklist:

[x] I have read and agree to the Code of Conduct.
[x] I have signed the Contributor License Agreement (CLA).
[x] I have considered the Security Policy.
[x] I have self-reviewed and tested my code.
[x] I have updated documentation as needed.
[x] I agree to the project's custom license.

Additional Notes:

CLAassistant commented 1 week ago

All committers have signed the CLA.

AbdulRashidReshamwala commented 23 hours ago

can you remove the packagelock changes from the pr will cause multiple issue during review

adithyaakrishna commented 3 hours ago

@shebll Could you pls resolve the conflicts?