recurly / recurly-client-php

Recurly PHP Client
http://recurly.com
MIT License
172 stars 93 forks source link

PHP8: Avoids a warning about the undefined variable in the case file_get_contents fails #822

Open Chikashi-Kato opened 1 month ago

Chikashi-Kato commented 1 month ago

E_WARNING: Undefined variable $http_response_header is reported when file_get_contents fails to fetch the specified $url. This seems to happen because HTTP Wrapper doesn't set $http_response_header when it fails.

Since PHP 8 accesses to undefined variables are reported as E_WARNING, this became more visible and noisier.

This PR avoids the warning by using a coalescing operator.