search

red-hat-storage / ocs-operator

Operator for RHOCS
Apache License 2.0
85 stars 184 forks source link

kms: skip checking azure kms endpoint reachability #2754

Closed sp98 closed 3 months ago

sp98 commented 3 months ago

Vault URL provided in the KMS settings does not have a port number. As a result, endpoint reachable check in checkEndpointReachable function fails. . This only works when we provide the default port of 443 and along with the URL. For now, we can simply avoid checking azure vault URL for endpoint reachability.

This fixes BZ - https://bugzilla.redhat.com/show_bug.cgi?id=2303619 which is a blocker for Azure customers using KMS

openshift-ci[bot] commented 3 months ago

@aruniiird: changing LGTM is restricted to collaborators

In response to [this](https://github.com/red-hat-storage/ocs-operator/pull/2754#pullrequestreview-2249783379): >Thanks @sp98 . LGTM from my side Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aruniiird, iamniting, sp98

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/red-hat-storage/ocs-operator/blob/main/OWNERS)~~ [iamniting] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
iamniting commented 3 months ago

/test ocs-operator-bundle-e2e-aws

iamniting commented 3 months ago

/cherry-pick release-4.17

openshift-cherrypick-robot commented 3 months ago

@iamniting: once the present PR merges, I will cherry-pick it on top of release-4.17 in a new PR and assign it to you.

In response to [this](https://github.com/red-hat-storage/ocs-operator/pull/2754#issuecomment-2301408946): >/cherry-pick release-4.17 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
sp98 commented 3 months ago

/test ocs-operator-bundle-e2e-aws

openshift-cherrypick-robot commented 3 months ago

@iamniting: new pull request created: #2759

In response to [this](https://github.com/red-hat-storage/ocs-operator/pull/2754#issuecomment-2301408946): >/cherry-pick release-4.17 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.