red-hat-storage / odf-cli

ODF CLI tool
Apache License 2.0
2 stars 10 forks source link

health: add health command #25

Closed subhamkrai closed 9 months ago

openshift-ci[bot] commented 9 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

travisn commented 9 months ago

@travisn odf get cluster-health sounds good or odf health small works better?

Looking back at the ODF CLI design doc, let's go with odf get health. It's good to have a verb in the command. With odf health there is no verb.

subhamkrai commented 9 months ago

based on the PR #23 , so added the label do-not-merge

subhamkrai commented 9 months ago

but testing looks good

 ./bin/odf get health
Info: Checking if at least three mon pods are running on different nodes
rook-ceph-mon-a-89ddf6c75-sp56z Running openshift-storage   ip-10-0-71-84.ec2.internal
rook-ceph-mon-b-9d98dccbc-jb4t7 Running openshift-storage   ip-10-0-8-11.ec2.internal
rook-ceph-mon-c-5bb58495d5-9tf4c    Running openshift-storage   ip-10-0-122-244.ec2.internal

Info: Checking mon quorum and ceph health details
Error: HEALTH_ERR

Info: Checking if at least three osd pods are running on different nodes
rook-ceph-osd-0-56b8d6ccc9-mhmls    Running openshift-storage   ip-10-0-8-11.ec2.internal
rook-ceph-osd-1-7b64c8ff49-njddt    Running openshift-storage   ip-10-0-71-84.ec2.internal
rook-ceph-osd-2-74557869c6-mqr4n    Running openshift-storage   ip-10-0-122-244.ec2.internal

Info: Pods that are in 'Running' or `Succeeded` status
csi-addons-controller-manager-b57db8956-dhnhv    Running     openshift-storage   ip-10-0-122-244.ec2.internal
csi-cephfsplugin-df97f   Running     openshift-storage   ip-10-0-8-11.ec2.internal
csi-cephfsplugin-hqkj4   Running     openshift-storage   ip-10-0-71-84.ec2.internal
csi-cephfsplugin-jqpvh   Running     openshift-storage   ip-10-0-122-244.ec2.internal
csi-cephfsplugin-provisioner-7468767c47-grxk7    Running     openshift-storage   ip-10-0-71-84.ec2.internal
csi-cephfsplugin-provisioner-7468767c47-pwvgc    Running     openshift-storage   ip-10-0-8-11.ec2.internal
csi-rbdplugin-5djqv      Running     openshift-storage   ip-10-0-8-11.ec2.internal
csi-rbdplugin-bd5cx      Running     openshift-storage   ip-10-0-122-244.ec2.internal
csi-rbdplugin-provisioner-7cfc8c7cf7-dl8nv   Running     openshift-storage   ip-10-0-8-11.ec2.internal
csi-rbdplugin-provisioner-7cfc8c7cf7-s7pkw   Running     openshift-storage   ip-10-0-122-244.ec2.internal
csi-rbdplugin-qzzcv      Running     openshift-storage   ip-10-0-71-84.ec2.internal
noobaa-operator-5bbb9cfd85-dnxcd     Running     openshift-storage   ip-10-0-122-244.ec2.internal
ocs-metrics-exporter-6c75f7bdc6-cj6f2    Running     openshift-storage   ip-10-0-122-244.ec2.internal
ocs-operator-5fcb67864b-vc67t    Running     openshift-storage   ip-10-0-122-244.ec2.internal
odf-console-7585b78b4-9frst      Running     openshift-storage   ip-10-0-122-244.ec2.internal
odf-operator-controller-manager-78f47ddf65-stpnd     Running     openshift-storage   ip-10-0-122-244.ec2.internal
rook-ceph-crashcollector-ip-10-0-122-244.ec2.internal-75f9ppzll      Running     openshift-storage   ip-10-0-122-244.ec2.internal
rook-ceph-crashcollector-ip-10-0-71-84.ec2.internal-d76b95fjzrm      Running     openshift-storage   ip-10-0-71-84.ec2.internal
rook-ceph-crashcollector-ip-10-0-8-11.ec2.internal-dc84fb7h77qv      Running     openshift-storage   ip-10-0-8-11.ec2.internal
rook-ceph-exporter-ip-10-0-122-244.ec2.internal-54d789974-4p7sz      Running     openshift-storage   ip-10-0-122-244.ec2.internal
rook-ceph-exporter-ip-10-0-71-84.ec2.internal-7b9b6d7579-9k7jt   Running     openshift-storage   ip-10-0-71-84.ec2.internal
rook-ceph-exporter-ip-10-0-8-11.ec2.internal-66f48c8ff9-nwdph    Running     openshift-storage   ip-10-0-8-11.ec2.internal
rook-ceph-mgr-a-7dc89565f5-vj879     Running     openshift-storage   ip-10-0-71-84.ec2.internal
rook-ceph-mon-a-89ddf6c75-sp56z      Running     openshift-storage   ip-10-0-71-84.ec2.internal
rook-ceph-mon-b-9d98dccbc-jb4t7      Running     openshift-storage   ip-10-0-8-11.ec2.internal
rook-ceph-mon-c-5bb58495d5-9tf4c     Running     openshift-storage   ip-10-0-122-244.ec2.internal
rook-ceph-operator-6557f9c6b5-z2zzv      Running     openshift-storage   ip-10-0-8-11.ec2.internal
rook-ceph-osd-0-56b8d6ccc9-mhmls     Running     openshift-storage   ip-10-0-8-11.ec2.internal
rook-ceph-osd-1-7b64c8ff49-njddt     Running     openshift-storage   ip-10-0-71-84.ec2.internal
rook-ceph-osd-2-74557869c6-mqr4n     Running     openshift-storage   ip-10-0-122-244.ec2.internal
rook-ceph-osd-prepare-0e5eaa6f75eba6b7674319908384edd1-rtvg8     Succeeded   openshift-storage   ip-10-0-71-84.ec2.internal
rook-ceph-osd-prepare-26463b8fe05e882dc71f99d7ee2f4139-hv8rl     Succeeded   openshift-storage   ip-10-0-122-244.ec2.internal
rook-ceph-osd-prepare-9c1e9a35577e54d37b0e0e0f11027626-fxfbv     Succeeded   openshift-storage   ip-10-0-8-11.ec2.internal

Warning: Pods that are 'Not' in 'Running' status
noobaa-core-0    Pending     openshift-storage   
noobaa-db-pg-0   Pending     openshift-storage   
rook-ceph-mds-ocs-storagecluster-cephfilesystem-a-84c7df65fsspp      Pending     openshift-storage   
rook-ceph-mds-ocs-storagecluster-cephfilesystem-b-cffbf4bd8bzqw      Pending     openshift-storage   

Info: Checking placement group status
Info:   PgState: active+clean, PgCount: 113

Info: Checking if at least one mgr pod is running
rook-ceph-mgr-a-7dc89565f5-vj879    Running openshift-storage   ip-10-0-71-84.ec2.internal
subhamkrai commented 9 months ago

based on the PR #23 , so added the label do-not-merge

JFYI @travisn

subhamkrai commented 9 months ago

based on the PR #23 , so added the label do-not-merge

JFYI @travisn

This is ready to review, I've removed the dependencies of above mentioned pr

subhamkrai commented 9 months ago

@travisn ^

openshift-ci[bot] commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: subhamkrai, travisn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/red-hat-storage/odf-cli/blob/main/OWNERS)~~ [subhamkrai,travisn] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 9 months ago

New changes are detected. LGTM label has been removed.