red-hat-storage / odf-cli

ODF CLI tool
Apache License 2.0
2 stars 10 forks source link

restore: add command to restore crd #31

Closed subhamkrai closed 8 months ago

subhamkrai commented 9 months ago

This commits add command restore crd which are stuck in terminating state.

openshift-ci[bot] commented 9 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

subhamkrai commented 9 months ago

@travisn

I was thinking to have a new command restore and it will have sub-commands like


- restore
  -  crds
  - mon-quorum

currently, to restore mon-quorum the command is odf mons restore-quorum <mon_id> but I like the first approach as it will be more easier for the user to find a command with restore. WDYT?

travisn commented 9 months ago

@travisn

I was thinking to have a new command restore and it will have sub-commands like

- restore
  -  crds
  - mon-quorum

currently, to restore mon-quorum the command is odf mons restore-quorum <mon_id> but I like the first approach as it will be more easier for the user to find a command with restore. WDYT?

Agreed, looks good to have the restore command.

openshift-ci[bot] commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: subhamkrai, travisn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/red-hat-storage/odf-cli/blob/main/OWNERS)~~ [subhamkrai,travisn] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment