red-hat-storage / odf-cli

ODF CLI tool
Apache License 2.0
2 stars 10 forks source link

build: update Go and K8s api version for odf-cli #68

Closed ShravaniVangur closed 4 months ago

ShravaniVangur commented 4 months ago

This commit updates the version of Go from 1.21 to 1.22.0 and updates the Kubernetes api versions accordingly.

openshift-ci[bot] commented 4 months ago

Hi @ShravaniVangur. Thanks for your PR.

I'm waiting for a red-hat-storage member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
subhamkrai commented 4 months ago

@ShravaniVangur can you try running go mod tidy, and see if toolchain * is added in go.mod file

ShravaniVangur commented 4 months ago

@subhamkrai These changes have been pushed after running the go mod tidy command and toolchain * has not been added.

subhamkrai commented 4 months ago

@subhamkrai These changes have been pushed after running the go mod tidy command and toolchain * has not been added.

I see, okay

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ShravaniVangur, subhamkrai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/red-hat-storage/odf-cli/blob/main/OWNERS)~~ [subhamkrai] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment