search

reddit / node-api-client

MIT License
90 stars 30 forks source link

Add endpoint for minsky post by subreddit recommendations #179

Closed keithblaha closed 7 years ago

keithblaha commented 8 years ago

:eyeglasses: @scarow @schwers

schwers-zz commented 8 years ago

:fish:

keithblaha commented 7 years ago

:haircut_woman: sorry to modify already :fish:ed PR but would like to piggy back this additional endpoint addition and fix an issue

scarow commented 7 years ago

Should the file names here change too? SubredditsByLink.es6.js instead of post?

scarow commented 7 years ago

:haircut_man:

keithblaha commented 7 years ago

So I had thought about the naming stuff at first and its problematic because within r2 they're called links, but consistently throughout 2X they're called posts. I decided it was least confusing to just stick with local naming across the board, even if that's slightly confusing across the platforms.

scarow commented 7 years ago

O0o0o that is annoying. Very well.

scarow commented 7 years ago

lgtm 🐟

keithblaha commented 7 years ago

added another endpoint... sorry to mess with it given it was already fished, but :haircut_woman:

keithblaha commented 7 years ago

bump - this was modified after the last fish (apologies again for that)

keithblaha commented 7 years ago

:eyeglasses: @prashtx @nramadas