search

redhat-aqe / review-rot

GNU General Public License v3.0
13 stars 16 forks source link

Phabricator Test Restructuring #95

Closed sidpremkumar closed 5 years ago

pbortlov commented 5 years ago

@sidpremkumar please rename test directory test/phabricator_test to test/phabricator_tests

pbortlov commented 5 years ago

@sidpremkumar what does the last push mean? If you want to work on the other tests please create a new branch for that. If this MR is ready for review, please remove WIP: from the name. Thank you :)

pbortlov commented 5 years ago

@sidpremkumar please resolve discussion which are outdated or you were fixed

lkrajice commented 5 years ago

Except those two comments I posted, this merge IMO is ready to be merged.

pbortlov commented 5 years ago

@sidpremkumar could you please fetch the origin/master and rebase this branch? --ignore-wip doesn't work

pbortlov commented 5 years ago

======================================================================
FAIL: test_get_reviews_last_comment (test.PhabricatorTest)

Traceback (most recent call last):
File "/home/pbortlov/git/github/review-rot/rev-venv/lib/python2.7/site-packages/mock-3.0.5-py2.7.egg/mock/mock.py", line 1330, in patched
return func(*args, **keywargs)
File "/home/pbortlov/git/github/review-rot/test/test.py", line 166, in test_get_reviews_last_comment self.config['msg3']) AssertionError: "dummy_user filed 'Title 1' dummy.url 6 years 9 months 12 days 12 hours ago, 3 comments, last comment by user_name 9 months 12 days 12 hours ago" != "dummy_user filed 'Title 1' dummy.url 6 years 8 months 22 days 15 hours ago, 3 comments, last comment by user_name 8 months 22 days 15 hours ago"

====================================================================== FAIL: test_get_reviews_no_raw (test.PhabricatorTest)

Traceback (most recent call last): File "/home/pbortlov/git/github/review-rot/rev-venv/lib/python2.7/site-packages/mock-3.0.5-py2.7.egg/mock/mock.py", line 1330, in patched return func(*args, **keywargs) File "/home/pbortlov/git/github/review-rot/test/test.py", line 141, in test_get_reviews_no_raw self.config['msg2']) AssertionError: "dummy_user filed 'Title 1' dummy.url 6 years 9 months 12 days 12 hours ago, 1 comment, last comment by user_name 9 months 12 days 12 hours ago" != "dummy_user filed 'Title 1' dummy.url 6 years $ months 22 days 15 hours ago, 1 comment, last comment by user_name 8 months 22 days 15 hours ago"

====================================================================== FAIL: test_request_reviews_no_repo (test.PhabricatorTest)

Traceback (most recent call last): File "/home/pbortlov/git/github/review-rot/rev-venv/lib/python2.7/site-packages/mock-3.0.5-py2.7.egg/mock/mock.py", line 1330, in patched return func(*args, **keywargs) File "/home/pbortlov/git/github/review-rot/test/test.py", line 71, in test_request_reviews_no_repo self.config['msg1']) AssertionError: "user_name filed 'Title 1' dummy.url 6 years 9 months 12 days 12 hours ago, 2 comments, last comment by user_name 6 years 9 months 12 days 12 hours ago" != "user_name filed 'Title 1' dummy.url 6 years 8 months 22 days 15 hours ago, 2 comments, last comment by user_name 6 years 8 months 22 days 15 hours ago"

====================================================================== FAIL: test_request_reviews_with_repos (test.PhabricatorTest)

Traceback (most recent call last): File "/home/pbortlov/git/github/review-rot/rev-venv/lib/python2.7/site-packages/mock-3.0.5-py2.7.egg/mock/mock.py", line 1330, in patched return func(*args, **keywargs) File "/home/pbortlov/git/github/review-rot/test/test.py", line 97, in test_request_reviews_with_repos self.config['msg1']) AssertionError: "user_name filed 'Title 1' dummy.url 6 years 9 months 12 days 12 hours ago, 2 comments, last comment by user_name 6 years 9 months 12 days 12 hours ago" != "user_name filed 'Title 1' dummy.url 6 years 8 months 22 days 15 hours ago, 2 comments, last comment by user_name 6 years 8 months 22 days 15 hours ago"