redhat-cop / agnosticd

AgnosticD - Ansible Deployer for multiple Cloud Deployers
https://redhat-cop.github.io/agnosticd/
GNU General Public License v3.0
383 stars 489 forks source link

AdmissionConfig ImagePolicy is not configured #186

Open jorgemoralespou opened 6 years ago

jorgemoralespou commented 6 years ago

This configuration needs to be configured in the cluster (ocp-workshop) for proper imagestream resolution to happen on nativee kubernetes objects (https://docs.okd.io/latest/admin_guide/image_policy.html#image-policy-configuring-the-image-policy-admission-plug-in).

Current version (3.10.14) get it's configuration from an environment variable. (https://github.com/sborenst/ansible_agnostic_deployer/blob/master/ansible/configs/ocp-workshop/files/hosts_template.3.10.14.j2#L125-L131)

The default value for the admissionPlugin in that environment variable is not properly set (https://github.com/sborenst/ansible_agnostic_deployer/blob/master/ansible/configs/ocp-workshop/env_vars.yml#L243-L253)

In previous releases (3.9.40) this configuration is commented out (https://github.com/sborenst/ansible_agnostic_deployer/blob/master/ansible/configs/ocp-workshop/files/hosts_template.3.9.40.j2#L120-L123), but applied in other previous releases like 3.9.31 (https://github.com/sborenst/ansible_agnostic_deployer/blob/master/ansible/configs/ocp-workshop/files/hosts_template.3.9.31.j2#L108)

Can we have this configuration consistently applied in every release? This is required.

jorgemoralespou commented 6 years ago

cc/ @grahamdumpleton @siamaksade @fridim @sborenst