Reuse ideas from the OpenShift Ansible guidelines, closes #2

redhat-cop / automation-good-practices

Recommended practices for all elements of automation using Ansible, starting with collections and roles, continuing with playbooks, inventories and plug-ins... These good practices are planned to be used by all Red Hat teams interested but can of course be used by others.

268 stars 66 forks source link

Reuse ideas from the OpenShift Ansible guidelines, closes #2 #37

Closed ericzolf closed 2 years ago

ericzolf commented 2 years ago

add examples around line length
speak mostly against JSON unless more readable
add note about not defining dangerous defaults in roles
use tasks or roles in playbooks
naming object_action and avoid numbering
speak against using package

mophahr commented 2 years ago

In the February 23 CoP meeting, we collectively approved the chages (up to the formatting issues already mentioned in the reviews) so this PR is ready to be merged as soon as the last open conversations are addressed/closed.

ericzolf commented 2 years ago

I think I addressed all comments, and generated the docs new. The simple comment about indentation of text led to reformat the whole roles/README.adoc... Na well, it needed to be done anyway...