redhat-cop / ee_utilities

This ansible collection includes a number of roles and tools which can be useful for managing Ansible Execution Environments.

https://galaxy.ansible.com/infra/ee_utilities

GNU General Public License v3.0

57 stars 34 forks source link

Fix dir removal issue #62

Closed rnozaki closed 1 year ago

rnozaki commented 1 year ago

What does this PR do?

Move the place where the temporary directory is deleted. Previously it was being deleted inside the loop, and when the next item was processed:

the directory had been deleted
the when condition was preventing the directory to be created again
further task would fail due to the directory being missing.

How should this be tested?

Manual

Is there a relevant Issue open for this?

Other Relevant info, PRs, etc

None

sean-m-sullivan commented 1 year ago

After review I am closing this, it was fixed in #57 and we should have released then, let me know if the new release fixes it.

rnozaki commented 1 year ago

Actually I had cloned #57 in my local repo, and that fix was not addressing the directory missing, from my tests. For some reason the logical condition remained in a way that the directory was deleted and not recreated, causing failures in a further task.