search

redhat-cop / helm-charts

Helm Charts Repository
https://redhat-cop.github.io/helm-charts
Apache License 2.0
104 stars 83 forks source link

Manage Operators console plugins with operators-install chart #571

Open jtudelag opened 2 weeks ago

jtudelag commented 2 weeks ago

operators-installer helm chart is great, but IMHO there is one missing feature regarding installing operators via OLM. Managing operator console plugins.

When installing operators via OLM using OpenShift UI, most of the times the operator console plugin is enabled by default, and taken care by OLM itself. Also most operators (at least Red Hat operators) come with their own console plugins.

When installing operators using GitOps, we are missing this functionality. I tried a simple approach here, and it worked. It is not idempotent at the moment, it will only take afew lines.

Also now that ArgoCD supports (since v2.10) a PostDelete hook, we could use that to do the cleanup of the plugin after uninstalling the operator.

@itewk leaving this here in case I have time to do a PR in the future.

itewk commented 2 weeks ago

@jtudelag it would be great to have a PR at least for your job you made for enabling the plugins with a boolean flag to enable or disable per operator, on by default.

i would love to dive into this myself, but can't focus on this right now. but happy to review / test when you get it working :)

jtudelag commented 2 weeks ago

@itewk I am afrad that might not be possible...the biggest challenge for users here is that plugin names are different and unique per operator with no name patern that allows any generalization...so the user needs to know the exact plugin name in advance for each specific operator....e.g: odf-plugin (ODF), gitops-console-plugin (GitOps) or logging-view-plugin (OCP Logging).

I havent seen yet any operator doc or OCP doc where plugin names are mentioned...so the user would need to install the operator manually in advance and lookup the plugin name in OCP before they can know it....

itewk commented 2 weeks ago

@jtudelag worse case we can have the paramter where they have to specify the plugin name. but i would think since the openshift UI is exposing a button to say "install the plugin" that it has some way of figburing it out, and since the UI does everything via the kube api, its got to be hiding somewhere. or maybe its doing some other weird magic.

jtudelag commented 2 weeks ago

alright, that is smart, I did not thought about that @itewk, then I will first investigate what is the "magic...