redhat-developer / openshift-vsts

OpenShift Extension for Azure DevOps.
Apache License 2.0
15 stars 20 forks source link

On the OC Setup command proxy didn't use for the versioned url even the proxy has specified #176

Open developertyrone opened 4 years ago

developertyrone commented 4 years ago

Seems on line 269 - 276 of oc-install.ts didn't use the proxy for versioned url even the proxy option has specified?

It may cause the oc setup to break if the pipeline agent is behind the web proxy.

    if (url) {
      // check if url is valid otherwise take the latest stable oc cli for this version
      const response = await fetch(url, { method: 'HEAD' });
      findURLofLatest = !response.ok;
    }
    if (findURLofLatest) {
      url = InstallHandler.ocBundleURL(version.value, osType, true);
    }

(Although the azure pipeline agent can specify proxy and proxy pass for self host agent as global setting. )