Fix yaml template - Githubissues

redhat-developer / osd-monitor-poc

8 stars 20 forks source link

Fix yaml template #38

Closed jmelis closed 5 years ago

jmelis commented 5 years ago

The serviceAccount was incorrectly listed under the params section
The roleBinding was missing

jmelis commented 5 years ago

@fche can you review?

fche commented 5 years ago

I believe the RoleBinding parts are privileged, and that ci/cd-invoked oc apply would fail if those clauses were in this yaml file. We omit them from the peer osd-monitor.yaml for the same reason.

jmelis commented 5 years ago

@fche: you're right, I removed it. Can you review and merge so I can apply this?