CodeAction to replace deprecated `#with` into `#let` section

[angelozerr]

In the future, Qute will deprecate #with section.

We should support diagnostic and quickfix fir that:

• report a diagnostic in #with with LSP deprecated diagnostic tag.
• provide a codeaction which transform #with with #let

Given this Qute template:

{@org.acme.qute.Item item}
{#with item}
   {name}
   {price}
{/with}

with should report a deprecated diagnostic and provide a code action to replace with:

{@org.acme.qute.Item item}
{#let name=item.name price=item.price}
   {name}
   {price}
{/let}

@mkouba what do you think about that?

[mkouba]

I'd rather recommend users to use {item.name} and {item.price} instead... but ofc the snippet {#let name=item.name price=item.price} is OK.

[angelozerr]

I'd rather recommend users to use {item.name} and {item.price} instead... but ofc the snippet {#let name=item.name price=item.price} is OK.

Okthanks for your feedback, we should provide this kind of quickfix in priority.

[AlexXuChen]

@mkouba In which version of Qute will #with be deprecated, and should we be setting #with as deprecated?

[mkouba]

@mkouba In which version of Qute will #with be deprecated, and should we be setting #with as deprecated?

There is no plan to deprecate the #with section so far. There is a big warning in the docs though and it explains that this section should not be used in type-safe templates or templates that define type-safe expressions. We could do the same in the ide, or?