redhat-developer / vscode-quarkus

Quarkus Tools for Visual Studio Code, by Red Hat
https://quarkus.io
Apache License 2.0
72 stars 28 forks source link

Qute is now supporting fragments #563

Open ia3andy opened 1 year ago

ia3andy commented 1 year ago
image image

It seems VSCode extension doesn't support this yet.

See https://quarkus.io/guides/qute-reference#fragments

cc @mkouba

angelozerr commented 1 year ago

Thanks for reporting this issue. We need to implement it.

ia3andy commented 1 year ago

@mkouba how do you sync new features with the tooling teams? Maybe those should be anticipated?

fbricon commented 1 year ago

@mkouba how do you sync new features with the tooling teams? Maybe those should be anticipated?

Yes they should :-)

mkouba commented 1 year ago

@mkouba how do you sync new features with the tooling teams? Maybe those should be anticipated?

Unfortunately, there is no sync process at the moment. I believe that we should just file a new issue here when a new feature lands in the main branch?

FTR Type-safe Fragments: https://quarkus.io/guides/qute-reference#type_safe_fragments

ia3andy commented 1 year ago

@fbricon if we create an issue here, is this synced in the team for all IDEs plugins?

fbricon commented 1 year ago

If the work only involves development on the https://github.com/redhat-developer/quarkus-ls side, then all IDEs will automatically reap the benefits. VS Code is the 1st consumer, Eclipse and IntelliJ will pick it up eventually. Anything that involves custom UI work, exposing settings and whatnot, requires custom client development. If @jeffmaury follows changes on the quarkus-ls repo, I think he should be able to follow up on the Eclipse and IntelliJ side of things on his own. Else we'll give him a nudge ;-)

angelozerr commented 1 year ago

For fragment it will require some work on JDT LS side, so @jeffmaury will need to do the same thing for IJ.

I have the intention to work on this issue.

angelozerr commented 1 year ago

@ia3andy in your sample I have the impression that when you write $ in method of TemplateInstance it defines the fragment id (noteList). Is it corect?

I have not found some documentation which explains that in https://quarkus.io/guides/qute-reference#fragments

Which support of fragment are you expecting?

mkouba commented 1 year ago

I have not found some documentation which explains that in https://quarkus.io/guides/qute-reference#fragments

I believe that this is documented in the Type-safe Fragments section (it's a quarkus-specific feature).

angelozerr commented 1 year ago

I believe that this is documented in the Type-safe Fragments section (it's a quarkus-specific feature).

Thanks for your clarification @mkouba

I started the support of fragment with https://github.com/redhat-developer/quarkus-ls/pull/768

You can notice that cmpletion, hover of section show now link(s) of the documentation

image

It will avoid for newbie (like me) to forget some part of documentation.

angelozerr commented 1 year ago

@ia3andy is it possible to share your project with fragment please, in order to that I play with it. Thanks.

angelozerr commented 1 year ago

@mkouba @ia3andy you can see a demo with my current work for fragment support at https://github.com/redhat-developer/quarkus-ls/pull/769#issuecomment-1386729827

Please add comments in this PR if you need some improvement , another features for fragment support, etc. Thanks.

ia3andy commented 1 year ago

@angelozerr sorry for the delay, here is the project: https://github.com/ia3andy/renotes/

angelozerr commented 1 year ago

@angelozerr sorry for the delay, here is the project: https://github.com/ia3andy/renotes/

Thanks so much @ia3andy I will try with your project to see if there are not some usecases that I could miss.