search

redhat-developer / yaml-language-server

Language Server for YAML Files
MIT License
1.1k stars 264 forks source link

Export Telemetry type #917

Open remcohaszing opened 1 year ago

remcohaszing commented 1 year ago

What does this PR do?

Export the Telemetry type.

Alternatively it could be defined in yamlLanguageService.ts.

What issues does this PR fix or reference?

This is used by monaco-yaml.

Is it tested? How?

No.

gorkem commented 1 year ago

Can we alternately add telemetry.ts to index.ts ? This would also export TelemetryEvent which I feel maybe needed if a client really wants to send events.

remcohaszing commented 1 year ago

I think you meant to move it into yamlLanguageService, of which everything is also re-exported in index.ts. Otherwise language service code would have to import language server code.

coveralls commented 11 months ago

Coverage Status

coverage: 84.071%. remained the same when pulling 4212cc98a05f78fe1a3f1e2856ead54b4992a181 on remcohaszing:export-telemetry into d354c58a480dd9d3ef6b754377352b481163f60a on redhat-developer:main.