add basic support for declaring schema with inline `$schema`

redhat-developer / yaml-language-server

Language Server for YAML Files

MIT License

1.01k stars 244 forks source link

add basic support for declaring schema with inline `$schema` #970

Open bollwyvl opened 1 month ago

bollwyvl commented 1 month ago

What does this PR do?

adds basic support for $schema
- this has second priority
- # yaml-language-server $schema=
- this feature
- customSchemaProvider

What issues does this PR fix or reference?

Is it tested? How?

test/fixtures/sample-dollar-schema.json added
test/schema.test.ts
- the modeline test is updated to include a $schema (which it ignores)
- a new test is added which only provides a $schema (which beats settings)

coveralls commented 1 month ago

coverage: 84.248% (+0.07%) from 84.174% when pulling b29478a84cd44bf4264ca778e418e5c76aacde8f on bollwyvl:gh-964-use-dollar-schema into f039273ee5b6974db5ad34b03bb24cfe09b64447 on redhat-developer:main.

bollwyvl commented 1 month ago

Looking more through older PRs and issues:

it appears some of the relevant argument there was in somehow ignoring $schema in additionalProperties... this PR doesn't propose anything like that, and the # yls modeline or by configuration would indeed be the only way in such a case.

bollwyvl commented 2 weeks ago

I see 1.15.0 went out :tada:... what can I do to help this get into the review pipeline, and hopefully make it into the next release?