redhat-openstack / easyfix

6 stars 5 forks source link

Remove **BuildRequires/Requires: python-pep8** from spec file #13

Open chkumar246 opened 7 years ago

chkumar246 commented 7 years ago

python-pep8 package is used to check the sanity and syntex of python code. During rpm building process, we donot perform syntex checking of the code as it is handled by project ci itself or by using tox.ini. In RDO Packages, at most places python-pep8 is used as BuildRequires or Requires.

What to improve:

  1. Clone keystoneauth1-distgit spec file by doing git clone https://github.com/rdo-packages/keystoneauth1-distgit
  2. Go to keystoneauth1-distgit and open python-keystoneauth1.spec in editor.
  3. You can find Requires: python-pep8 OR/AND BuildRequires: python-pep8 in spec file.
  4. We need to remove those lines from spec file.
  5. Once done! Make changes, add and commit it and send a Gerrit Review.
  6. Please cross checklist before sending Gerrit Review.

Example Spec containing the above fix:

  1. python-oslo-service

Below is the list of packages which need same fixes:

Mentors

  1. chandankumar
snecklifter commented 7 years ago

@chkumar246 I think senlin unit tests require python-pep8?

See comment against patch 29

https://review.rdoproject.org/r/#/c/7470/