search

redhat-openstack / openstack-puppet-modules

Puppet modules shared between Packstack and TripleO
39 stars 52 forks source link

Rename the n1k module directory #274

Closed imcsk8 closed 9 years ago

imcsk8 commented 9 years ago

Change the name of the n1k module directory from n1k-vsm to n1k_vsm as asked by this bug: https://bugzilla.redhat.com/show_bug.cgi?id=1195869

The name of this module in openstack-puppet rpm is n1k-vsm. Seems like puppet doesnt like that module name. Could you please change it to n1kvsm(not "-" its "" )?

This puppet module is only used by cisco with "Generic RHEL 7" host group and does not affect any other puppet classes or installer logic.

strider commented 9 years ago

Travis is failing because you need to rename the directory as well!

imcsk8 commented 9 years ago

this is odd, i did rename the directory. you can see it in the files changed section

imcsk8 commented 9 years ago

actually the test is failing because the directory name change, how can we fix this?

Missing ./n1k-vsm/Rakefile, not running spec tests. You have to manually check whether this is OK.

javierpena commented 9 years ago

I think this is an issue in the .travis.sh script. It tries to check which modules should be tested by doing a "git diff HEAD~1 Puppetfile", which in this case shows the old and the new names. n1k_vsm tests work fine, but there is no n1k_vsm directory, so it fails.

tl;dr: I think we can just merge this one if the cisco testing is fine for them and does not break Packstack or Staypuft.

javierpena commented 9 years ago

Tested with Packstack. As expected nothing was broken.

paramite commented 9 years ago

Agree on merging. I don't see any problem with this PR.