fix UNICODE issues: - Githubissues

redhotpenguin / perl-Archive-Zip

Archive::Zip as seen at https://metacpan.org/pod/Archive::Zip

Other

15 stars 44 forks source link

fix UNICODE issues: #25

Closed xlat closed 8 years ago

xlat commented 8 years ago

! addFile, addDirectory, addTree : on MSWin32 and $A:Z:UNICODE = 1, the externalFileName was used in place of newName ! memberNames : with $A:Z:UNICODE = 1, the returned file names was not upgraded in utf8 but already contain utf8 bytes.

Encode::encode_utf8 and Encode::decode_utf8 is not plateform dependent anymore.

redhotpenguin commented 8 years ago

Overall code looks good. I can't test on win32, so I'm going to go ahead and merge this. Care to add a Changes entry so I can make a release?

xlat commented 8 years ago

Thx, Yes I'll do.

xlat commented 8 years ago

It's done in c0272a1, but it would be nice to test on [l]unix env too.