search

redis / hiredis-rb

Ruby wrapper for hiredis
BSD 3-Clause "New" or "Revised" License
320 stars 90 forks source link

[Fedora] ExtConnectionTest#test_recover_from_partial_write failure #62

Open pvalena opened 5 years ago

pvalena commented 5 years ago

Hello,

In Fedora we're running the test suite, still with your ext. built against system hiredis 0.13.3, and I've encountered this issue:

  1) Error:
ExtConnectionTest#test_recover_from_partial_write:
Errno::EAGAIN: Resource temporarily unavailable
    /builddir/build/BUILD/hiredis-0.6.3/usr/share/gems/gems/hiredis-0.6.3/test/connection_test.rb:295:in `flush'
    /builddir/build/BUILD/hiredis-0.6.3/usr/share/gems/gems/hiredis-0.6.3/test/connection_test.rb:295:in `block in test_recover_from_partial_write'
    /builddir/build/BUILD/hiredis-0.6.3/usr/share/gems/gems/hiredis-0.6.3/test/connection_test.rb:73:in `listen'
    /builddir/build/BUILD/hiredis-0.6.3/usr/share/gems/gems/hiredis-0.6.3/test/connection_test.rb:285:in `test_recover_from_partial_write'

If I run it with rescue on the failing flush, I get:

  1) Failure:
ExtConnectionTest#test_recover_from_partial_write [/builddir/build/BUILD/hiredis-0.6.3/usr/share/gems/gems/hiredis-0.6.3/test/connection_test.rb:300]:
Expected false to be truthy.

So it does not seem to recover.

Could you advice me what's the issue? I've reverted 5284a0403bca7fbd9a086f9d8501a053a65beb67, to be able to build. Is there something else I need to revert?

Thank you for your advice.