Add option to disable making `CLIENT SETINFO` command on initialization

redis / rueidis

A fast Golang Redis client that supports Client Side Caching, Auto Pipelining, Generics OM, RedisJSON, RedisBloom, RediSearch, etc.

Apache License 2.0

2.34k stars 149 forks source link

Add option to disable making `CLIENT SETINFO` command on initialization #622

Closed rahulgkatre closed 2 weeks ago

rahulgkatre commented 2 weeks ago

This pull request addresses #620 and adds a DisableClientSetInfo constant to be used for the ClientSetInfo field of ClientOption.

When this constant is used, the CLIENT SETINFO command and relevant paths are skipped during new connection initialization, in order to be compatible with older versions of Redis (<7.2) that do not have the CLIENT SETINFO command.

Add DisableClientSetInfo path and test

rahulgkatre commented 2 weeks ago

Is there a way I can create a release of this change to use in my project?

rueian commented 2 weeks ago

Is there a way I can create a release of this change to use in my project?

I can tag a new alpha version tomorrow.

reagankan commented 2 weeks ago

Hello @rueian, have you had a chance to create an alpha version? We need to consume this ASAP, preferably today or monday/tuesday Sept 2,3. Thanks in advance.

rueian commented 2 weeks ago

Hi @rahulgkatre, @reagankan,

I have tagged the v1.0.46-alpha.1. You can change your go.mod to that.

I would also like to know why you need this. I thought the CLIENT SETINFO should be in a fire-and-forget manner and should not block you.