search

redpanda-data / helm-charts

Redpanda Helm Chart
http://redpanda.com
Apache License 2.0
73 stars 96 forks source link

redpanda: support `common{Pod,}{Labels,Annotations} ` #1433

Closed chrisseto closed 3 weeks ago

chrisseto commented 1 month ago

The redpanda chart currently supports a commonLabels field that propagates to all Labels fields. We should add a similar field for annotations.

JIRA Link: K8S-301

chrisseto commented 1 month ago

After a bit more conversion with @vuldin, we realized there's a bit missing here. We'll want to support both commonLabels, commonAnnotations, and provide a way to propagate them to PodTemplates (e.g. Jobs and StatefulSets).

I'd prefer to steal kustomize's solution of using an annotations transformer but I don't think it's work implementing all of kustomize in the helm chart.

Maybe splitting this into 4 total fields common{Pod,}{Labels,Annotations} is the best option for now as it'll be a bit more clear and backwards compatible.

chrisseto commented 3 weeks ago

I'm closing this as the original need for this ticket (the ability to set labels/annotations on Job pods) has been solved by this PR https://github.com/redpanda-data/helm-charts/pull/1477.

Reasoning about how label/annotation merging should be handled is difficult as we don't want to suddenly change existing deployments. So I'm going to slap "won't do" on here. Feel free to re-open if this feature is needed/strongly desired.