rpk: Convert all kafka client initializations to our kafka package.

redpanda-data / redpanda

Redpanda is a streaming data platform for developers. Kafka API compatible. 10x faster. No ZooKeeper. No JVM!

https://redpanda.com

9.69k stars 591 forks source link

rpk: Convert all kafka client initializations to our kafka package. #7192

Open r-vasquez opened 2 years ago

r-vasquez commented 2 years ago

Follow Up for: https://github.com/redpanda-data/redpanda/pull/7047#discussion_r1018188608

rpk has it's own kafka package with a method NewClient which creates a kgo client, we should use this package for all of our initialization of kafka clients across rpk.

Currently, prometheus-config and container create their own client and don't use our rpk kafka package.

JIRA Link: CORE-1076

twmb commented 2 years ago

This should wait for #4538. To properly convert, we should support common configuration flags. This will add 7 flags, and in the prometheus case, will drown out --node-addrs being used as-is. It'll make the help text more confusing.