search

redstreet / beancount_reds_plugins

Miscellaneous plugins for Beancount double entry accounting
GNU General Public License v3.0
96 stars 18 forks source link

Zerosum: mark unmatched transactions #2

Closed wzyboy closed 5 years ago

wzyboy commented 5 years ago

Hi,

thank you for your zerosum plugin! It saved me from the tedious deduplication process and the dilemma of choosing which date to smudge when dealing with trasfer transactions.

I made a little improvement to the zerosum plugin: It now mark unmatched transactions as warnings ("!" flag), which helps the user to find which transaction caused the balance of ZSA to be non-zero.

This pull request also includes some cosmetic chnages to make the file conform PEP8.

redstreet commented 5 years ago

Thank you, @wzyboy! I'm on a trip right now, but will take a look as soon as I get back next week.

wzyboy commented 5 years ago

When I opened the PR, I did not notice that I was working on a stale fork (it turns out that I forked this repo back in 2016-03), so it took me some time to follow the changes and to resolve the conflicts.

Now the PR should work.

redstreet commented 5 years ago

Great, thanks again!

Stale fork was not your fault: I pushed some commits today.