redstreet / fava_investor

Comprehensive set of reports, analyses, and tools for investments, for Beancount and Fava (plain text, double entry accounting software). Includes Fava plugins, command line tools, and libraries for each module.
GNU General Public License v3.0
136 stars 20 forks source link

Support for next fava release #97

Open ranebrown opened 3 days ago

ranebrown commented 3 days ago

Fava has merged support for beancount v3 which I assume means it will be included in the next release. This breaks fava_investor since query functionality was changed (query_shell changed to query). Do you have plans to update before the next fava releae?

Support for Beancount version 3 was added. Using Beancount 2 is still supported. Beancount query support is now provided by the beanquery package, which has some minor differences in syntax, the provided columns and functions to the bean-query functionality in Beancount version 2. For extensions using Fava's query_shell directly, this will lead to breakage due to differences in methods and the types that are returned.

redstreet commented 3 days ago

Thanks for the heads up! I'd love for fava_investor to stay up to date with all the work around v3. I lack the full bandwidth required right now, so I'd definitely appreciate either a PR or pointers to the specifics of what has changed what needs to be fixed, or anything else at all that might be helpful.