search

reduxjs / angular-redux

Official Angular bindings for Redux
MIT License
61 stars 6 forks source link

Add support for DI overwriting #1

Open crutchcorn opened 3 weeks ago

crutchcorn commented 3 weeks ago

In the React and Vue adapters, you can overwrite where the DI comes from in useDispatch and useSelector by passing a context to createDispatchHook (or similarly named)

Let's introduce this functionality to the Angular adapter as well

ghost commented 3 weeks ago

Hi @crutchcorn ✋ can I contribute? It looks promising 👍

crutchcorn commented 3 weeks ago

Hey @paweltwardziak! I actually think this is going to be a pretty involved effort for this specific feature, but are you at all interested in helping with documentation? I can make some new issues and assign them to you if you are 😄

ghost commented 3 weeks ago

Sure thing @crutchcorn :) I am open for any kind of contribution even though it would be great to get involved into something more challenging 👍 ;) Gimme that docs issue 🔥

nomadts commented 3 weeks ago

Hi @crutchcorn Looks promising 🤩 I also would love to contribute

crutchcorn commented 2 weeks ago

Love the excitement around the project, thanks y'all!

I'm actually not super sure if I want to do this issue in the end, as it's not as needed due to how Angular's DI system works and allows for overrides in other ways.

I'm gonna close this and open some other tickets that folks can take on. 😄 I'll post them here!