reduxjs / redux

A JS library for predictable global state management
https://redux.js.org
MIT License
60.93k stars 15.27k forks source link

fix(docs): correct grammar in part-2-app-structure tutorial regarding… #4742

Closed yakksiek closed 2 months ago

yakksiek commented 2 months ago

… Redux store access


name: :memo: Documentation Fix about: Fixing a problem in an existing docs page

Checklist

What docs page needs to be fixed?

What is the problem?

The sentence "If we have access to the Redux store, we could write some async code and call store.dispatch() when we're done" contains a grammatical inconsistency. It mixes present tense ("have") with a conditional phrase ("could"). This implies that access to the Redux store is hypothetical, but the grammar does not reflect this.

What changes does this PR make to fix the problem?

The sentence has been changed to: "If we had access to the Redux store, we could write some async code and call store.dispatch() when we're done."

This change aligns the tense and better reflects the hypothetical scenario.

codesandbox-ci[bot] commented 2 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

netlify[bot] commented 2 months ago

Deploy Preview for redux-docs ready!

Name Link
Latest commit 7e1975bc1a991e78597725b36a37c34756defb7a
Latest deploy log https://app.netlify.com/sites/redux-docs/deploys/66ec4c8461671e000888ce6a
Deploy Preview https://deploy-preview-4742--redux-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

timdorr commented 2 months ago

Thanked!