search

reduxjs / redux

A JS library for predictable global state management
https://redux.js.org
MIT License
60.93k stars 15.27k forks source link

Add redux.dev course callouts #4748

Closed lynnandtonic closed 2 weeks ago

lynnandtonic commented 3 weeks ago

Hi Mark! This PR:

I wasn’t sure how to add the callouts to the internal docs pages (I’m not super familiar with docusaurus), is that something you could help me with?

Here is where I was thinking we could place them (either mid at the bottom of the main column or narrow in the right sidebar). Also open to your suggestions here!

callout-placement-docs

We could also potentially add the wide one above the nav (only on the homepage) if we wanted it higher up on the page. (Though not great for mobile and we’d probably want to hide or swap out there)

callout-placement-home

Let me know what you think works and if there’s anything else I can provide. Thanks!

codesandbox-ci[bot] commented 3 weeks ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

netlify[bot] commented 3 weeks ago

Deploy Preview for redux-docs ready!

Name Link
Latest commit b7ce658933a0df3f391f0b8c6871f61e1ac7090d
Latest deploy log https://app.netlify.com/sites/redux-docs/deploys/672407fc27954b00081d9f9e
Deploy Preview https://deploy-preview-4748--redux-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

markerikson commented 2 weeks ago

Thanks! Since the PR is from your master branch, I'll just merge this and then fiddle with it a bit - probably going to add the "wide" version as a sitewide banner for the next few weeks. I'll also add it to the RTK and React-Redux sites as well.

markerikson commented 2 weeks ago

Done! Updated all 3 docs sites ( https://redux.js.org, https://redux-toolkit.js.org , https://react-redux.js.org ) with the same top banner and front-page image.

Thanks!