search

redwoodjs / redwoodjs.com

redwoodjs.com redesign for 1.0
21 stars 23 forks source link

normalize.css -> modern-normalize #48

Closed pavelloz closed 2 years ago

pavelloz commented 2 years ago

Hello,

Have you thought about switching normalize.css to modern normalize? Ive seen many modern projects switching, and it seems like the approach is pretty in line with your target group (devs usually dont use ie 11 nowadays :) )

Repo: https://github.com/sindresorhus/modern-normalize

cannikin commented 2 years ago

Do we have an explicit include of normalize? I thought that was included by Tailwind itself? Is it possible to override with something else?

pavelloz commented 2 years ago

Ouh, i think i made a mistake. There is a file that contains normalize.css comment, but everything below is not normalize at all - i got fooled :)

I think you are right about Tailwind - it has normalize, and to be precise, modern-normalize that i proposed, so all good. https://tailwindcss.com/docs/preflight#overview

Sorry for confusion.

cannikin commented 2 years ago

I think it may have started as normalize but then we customized it a bit (prefixed with .rw-scaffold). If you have any improvements feel free to PR!

pavelloz commented 2 years ago

@cannikin Im far too fresh in the codebase yet to suggest something, need a little bit more time. Until then I will contribute on the subject that im very confident in: performance :)

Organizational question: Should I create PRs if previous ones are not merged? I dont want to:

  1. swamp anyone
  2. create potential conflicts with any other plans
  3. create PRs that will be open for long time
jtoar commented 2 years ago

Should I create PRs if previous ones are not merged?

TL;DR yes, but you're right in that we need to get better at moving the PRs we have forward. But still, if you want to improve something, by all means, please make a PR!