search

redwoodjs / redwoodjs.com

redwoodjs.com redesign for 1.0
21 stars 23 forks source link

Update redwood.toml functions path. #81

Closed noire-munich closed 2 years ago

noire-munich commented 2 years ago

Change redwood.toml functions path from .netlify to .redwood - not sure why we still have .netlify, I thought it was changed to be normalized and avoid having adapting this per provider. Plus: locally it should be .redwood afaik.

This requires a change in netlify configuration upon merge.

netlify[bot] commented 2 years ago

Deploy Preview for redwood-sprout ready!

Name Link
Latest commit c2826f36fcfd83f1e4ad6314c24117d82d34b38e
Latest deploy log https://app.netlify.com/sites/redwood-sprout/deploys/629f1bb8c0daa9000818331a
Deploy Preview https://deploy-preview-81--redwood-sprout.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

cannikin commented 2 years ago

Hmm, isn't the site deployed to Netlify? This path has to be /.netlify for their functions to work, doesn't it?

cannikin commented 2 years ago

Are you thinking of doing something like this? https://www.jamesqquick.com/blog/how-to-redirect-netlify-functions-to-a-simpler-path

I mean, I guess we can, but it's not like anyone sees the function paths, that's all happening behind the scenes...

noire-munich commented 2 years ago

Yeah I admit I wasn't too convinced myself... I picked up the project today to catch up with some PR, update the framework and move things forward, since last time there were two major changes: ubuntu's latest release ( affects prisma ) and a bump from Redwood 0.50.0 to 1.5.0.

While doing it I noticed my api calls were not working anymore, so I debugged and found out that this modification was helping. I prepared this PR and moved on to my other tasks, but quite frankly it appears I cannot reproduce the issue.

So... Unless this happens again and I can reproduce it + report, I suppose we can close this.