search

reef-technologies / cookiecutter-rt-django

CookieCutter template for Django application projects with docker-compose etc.
BSD 3-Clause "New" or "Revised" License
19 stars 24 forks source link

Added healthcheck endpoint #179

Closed adal-chiriliuc-reef closed 7 months ago

adal-chiriliuc-reef commented 7 months ago

Uses https://github.com/revsys/django-health-check

adal-chiriliuc-reef commented 7 months ago

I have disabled the Celery healthchecks, on dev celery containers are not started so the celery healthchecks are always failing

I could try detecting if we are running in dev mode, or maybe we can start celery on dev too

mjurbanski-reef commented 7 months ago

@adal-chiriliuc-reef please remove disable celery healthchecks commit

It just proves it works correctly if it fails when celery is not working. I see no downside to this behavior - its not like any automatic process is watching it locally. Tell me if you see something here I dont. At the same time we do want it by default in prod when celery is enabled.

adal-chiriliuc-reef commented 7 months ago

OK, will remove.

The downside I see is that a default cookiecutter project will fail the healthcheck when run in dev mode, which is a bit of a bad look.

adal-chiriliuc-reef commented 7 months ago

@mjurbanski-reef anything left to do?

mjurbanski-reef commented 7 months ago

no, it just waits for you to merge it :P