reef-technologies / cookiecutter-rt-django

CookieCutter template for Django application projects with docker-compose etc.
BSD 3-Clause "New" or "Revised" License
19 stars 24 forks source link

RT-147 allauth #185

Closed kkowalski-reef closed 4 months ago

kkowalski-reef commented 6 months ago

Intorduces optional integration with django-allauth (!) new cookiecutter variables:

Streamlined config available for providers:

kkowalski-reef commented 5 months ago

@agoncharov-reef I agree that this PR doesn't really do much.

It feels to me that in general, I don't really know what settings we would prefer to pull up to the cookiecutter options - lots of allauth things can be simply changed via settings.py - email verification etc.

The templates are project specific and the included one is not pretty but functional. I'd say there is no need to overwrite them in cookiecutter.

Regarding enabling specific providers via cookiecutter options - there are >100 of them. However I see that we probably won't care about most of them ever, so Google / Apple / other popular ones could make sense to be exposed in cookiecutter options - I'll do that.

Enabling/disabling signups - I would see this more as a dynamic setting? Could be a part of the constance config.

mjurbanski-reef commented 5 months ago

require email confirmation?

I cannot really imagine a case in which you allow autoregistration and do not require email confirmation. It should be either confirmed by SSO (that is an email provider as well (this is important to verify)) or by email directy.

kkowalski-reef commented 5 months ago

I made this PR a bit more opinionated and took the suggestion from @mjurbanski-reef . To summarize the configuration requirements:

There are a bunch of default settings that will:

I believe this should make it so that you can mostly "just enable allauth" and have a working setup.