search

reesef / php-twig

This is a conversion of Anomareh / PHP-Twig.tmbundle for atom
35 stars 19 forks source link

Package.loadSettings is deprecated. #17

Closed kei0719 closed 9 years ago

kei0719 commented 9 years ago

Store package settings files in the settings/ directory instead of scoped-properties/

Package.loadSettings (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:552:9)
<unknown> (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:168:43)
Package.measure (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:147:15)
Package.load (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:161:12)
taeram commented 9 years ago

I'm seeing this same issue, as reported by the Deprecation Cop in Atom 0.196.0, but with different line numbers:

Store package settings files in the settings/ directory instead of scoped-properties/

Package.loadSettings (C:\Atom\resources\app.asar\src\package.js:566:9)
<unknown> (C:\Atom\resources\app.asar\src\package.js:168:43)
Package.measure (C:\Atom\resources\app.asar\src\package.js:147:15)
Package.load (C:\Atom\resources\app.asar\src\package.js:161:12)

This issue is also duplicated by #18 and #19.

mrpastewart commented 9 years ago

Same here

khanhicetea commented 9 years ago

Temporary solution : go to ~/.atom/packages/php-twig and change folder scoped-properties to settings

@reesef Please merge pull request, thank you :smile:

bobrocke commented 9 years ago

@khanhicetea Cool! Now the depreciation cop says I have 0 depreciations!