search

refinedmods / refinedstorage

An elegant solution to your hoarding problem.
https://refinedmods.com/refined-storage
MIT License
362 stars 177 forks source link

Fix poseStack translation leak in JEI RecipeTransferCraftingGridError #3718

Open mezz opened 4 months ago

mezz commented 4 months ago

Fix for

RS has a poseStack.translate with pushing and popping the stack, resulting in a leaked translation.

Before fix, hovering over the crafting button would shift GUI elements around: Bug JEI - Refined

After fix: Screenshot 2024-07-26 at 8 53 45 AM

I added mitigation for this in JEI as well but I think this is the "correct" place for the fix to be.

mezz commented 4 months ago

Note this issue does not exist in refinedstorage-jei-integration for 1.21, the push and pop are there: https://github.com/refinedmods/refinedstorage-jei-integration/blob/3ae49100628b59bee6c553e94f3ad4003e022755/refinedstorage-jei-integration-common/src/main/java/com/refinedmods/refinedstorage/jei/common/MissingItemRecipeTransferError.java#L49-L52