search

refinery / refinerycms-page-images

Adds an images tab to your pages so you can format a group of images really nicely on the frontend
104 stars 120 forks source link

Correct example code for images_with_captions #110

Closed anitagraham closed 10 years ago

parndt commented 10 years ago

I don't understand the change in the examples, can you explain how this improves things?

anitagraham commented 10 years ago

It missing the .each

parndt commented 10 years ago

Ah - but also, all the markup has changed?

anitagraham commented 10 years ago

iirc, at the time I added the each I got errors using dot-notation so I switched to [:symbol] because it worked. Did I change the markup as well? I know I tend to use <figure><figcaption /></figure>, but I probably thought to leave all the examples producing equivalent markup.

bricesanchez commented 9 years ago

What the status of this PR ? With the @anitagraham's example captions are working again.

parndt commented 9 years ago

The PR is closed

bricesanchez commented 9 years ago

We should perhaps cherry-pick Correct code example for images_with_captions e8d802a. Because the snippet of code in master doesn't works