search

refinery / refinerycms-page-images

Adds an images tab to your pages so you can format a group of images really nicely on the frontend
104 stars 120 forks source link

Revert "Fix images_with_captions code snippet in README" #124

Closed parndt closed 9 years ago

parndt commented 9 years ago

Reverts refinery/refinerycms-page-images#123

@anitagraham wasn't happy

parndt commented 9 years ago

I deliberately used <figure> and <figcaption> in the third example as they are the appropriate HTML5 elements. There are already two examples on the page using <ul>/<li>/<span class=‘caption’>.

If you must have three sets of close to identical tags, then use HTML5.

  • @anitagraham
bricesanchez commented 9 years ago

Ok, so the problem is the usage of ul li instead of figure tags not the ruby code ? So i should update the README to re-add HTML5 tags ?!

parndt commented 9 years ago

Just use my revert branch and commit only Ruby changes, or we can figure out why you can't use dot notation.. up to you?

bricesanchez commented 9 years ago

Done @parndt ! Thanks for your feedback @anitagraham, i want you happy :)

parndt commented 9 years ago

@anitagraham what do you think?

anitagraham commented 9 years ago

happy. :smiley: