reid / node-jslint

The JavaScript Code Quality Tool — for Node.js.
http://jslint.com/
Other
491 stars 101 forks source link

"--passfail false" does not stop processing #124

Closed smikes closed 9 years ago

smikes commented 9 years ago

Spin off of issue #39

smikes commented 9 years ago

I cannot reproduce this with jslint@latest. Here is what I see:

Svarog:node-jslint smikes$ jslint --passfail true test/fixtures/bad.js 

test/fixtures/bad.js
 #1 Unexpected dangling '_' in '__evil'.
    var __evil = eval( "3" ); // Line 1, Pos 5
 #2 Stopping. (50% scanned).
     // Line 1, Pos 5
Svarog:node-jslint smikes$ jslint --passfail false test/fixtures/bad.js 

test/fixtures/bad.js
 #1 Unexpected dangling '_' in '__evil'.
    var __evil = eval( "3" ); // Line 1, Pos 5
 #2 Unexpected space between '(' and '3'.
    var __evil = eval( "3" ); // Line 1, Pos 20
 #3 Unexpected space between '3' and ')'.
    var __evil = eval( "3" ); // Line 1, Pos 24
 #4 eval is evil.
    var __evil = eval( "3" ); // Line 1, Pos 14
Svarog:node-jslint smikes$ 

As expected, I see one error, and the "Stopping" indication when --passfail is true, and multiple issues when --passfail is false.

Can you please provide a repro set?

smikes commented 9 years ago

@jaseemabid, @mcandra could one of you please document the commands, version of node-jslint, and edition of jslint that you are using when you see this failure?

smikes commented 9 years ago

Closing this pending a repro case.. @mcandre or @jaseemabid can you provide one?